Add type annotations to cairo_renderer.py
#4393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmuenkel
commented
Aug 11, 2025
| self.static_mobjects: list[Mobject] = [] | ||
| self.time_progression: tqdm[float] | None = None | ||
| self.duration: float | None = None | ||
| self.duration: float = 0.0 |
There was a problem hiding this comment.
As far as I can tell setting self.duration = 0.0, will not cause any problems, but it avoids having to deal with it being None when calculating number of static frames or self.time.
fmuenkel
commented
Aug 11, 2025
| Iterable[Mobject] | ||
| The static image computed. | ||
| """ | ||
| self.static_image = None |
There was a problem hiding this comment.
For consistency with other methods and variables self.static_image should ideally be renamed to self.static_frame, but that can be done in another PR.
chopan050
requested changes
Aug 13, 2025
Co-authored-by: Francisco Manríquez Novoa <[email protected]>
Co-authored-by: Francisco Manríquez Novoa <[email protected]>
Co-authored-by: Francisco Manríquez Novoa <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
3 tasks
chopan050
approved these changes
Oct 24, 2025
github-project-automation
bot
moved this from 👀 In review
to 👍 To be merged
in Dev Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
More work towards completing #3375.
Motivation and Explanation: Why and how do your changes improve the library?
This PR includes some type annotations to
utils/hashing.pyto complete typing forcairo_renderer.py. Typing forutils/hashing.pyshould be completed in another PR.Reviewer Checklist